Fix font fallback Safari 10 for iOS #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/fontwatchrunner.js
Outdated
| this.started_ = goog.now(); | ||
| if (FontWatchRunner.hasWebKitFallbackBug()) { | ||
| this.lastResortWidths_[FontWatchRunner.LastResortFonts.MOCK_FONT] = this.getMockFontWidth_(); | ||
| } | ||
|
|
There was a problem hiding this comment.
diff gets a bit confused here because you've removed an empty line after this.started_ = goog.now();
dengjeffrey
force-pushed
the
fix/font-fallback-safari
branch
from
837fc3f
to
cb19ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR tries to accomplish
Partially fixes Font families might not really loaded in WebKit based browsers in specific networks conditions #365, for the iOS portion.
FontRulerwill report a width that is different than any of the fallbackFontRulerwidths.Extend coverage of Disable native font loading in Safari 10 #352 for iOS devices running Safari 10.
navigator.userAgentfor iOS devices do not contain*Version\/10match which fails the check for when to use the native loaderHow it accomplishes them
FontRulerfor a mock font with the same styling and record the width as alastResortWidth.lastResortWidthAppleWebKitversion to determine if webkit version is equivalent to the one used in Safari 10